Add HeroBanner #1125
Add HeroBanner #1125
Conversation
|
Wasn't supposed to be full-width, something like this: I think we dont need separator between the buttons and we need bigger text and biggers buttons. |
|
idk if this is related to this PR, but on for some reason everytime I try to login and authenticate, I get hit with this:
|
| } | ||
|
|
||
| &__content { | ||
| margin: auto 0; |
There was a problem hiding this comment.
I think you might be able to get rid of this if you are going to make the herobanner take up the entire screen width. And underneath &__content somewhere after around line 87 you can add the following flex properties:
align-items: center;
justify-contenter: center;
And then doing a few changes around like so:
in HeroBanner.js:
in Page.js:
in HeroBanner.less:
Here's what I have in my local, after checking out your fork and branch, and testing it out.
sry for the screenshots, but the git GUI that I use doesn't let me copy and paste lol.....
src/client/components/Utils/Affix.js
Outdated
| this.baseTopPosition = this.relativeContainer.getBoundingClientRect().top + this.lastScroll; | ||
|
|
||
| if (this.relativeContainer.parentElement) { | ||
| this.mo = new MutationObserver(() => { |
There was a problem hiding this comment.
I have never used MutationObserver before but I trust that this works 🤣
| import { getIsAuthenticated, getIsLoaded, getIsBannerClosed } from '../reducers'; | ||
| import { closeBanner } from '../app/appActions'; | ||
|
|
||
| export default connect( |
There was a problem hiding this comment.
I really like this idea, having a Container component that is a wrapper for the main component, and it handles all the state properties 👍
| @@ -24,6 +24,7 @@ | |||
| float: left; | |||
| display: none; | |||
| width: @left-width; | |||
| min-height: 1px; | |||
There was a problem hiding this comment.
won't need this anymore if banner is full width of the screen
|
had some small comments, but once @bonustrack approves it, its fine with me |
|
Can we have bigger buttons? And can we center the content on small screen? |
|
The margin in top should not be bigger than margin in down |
Fixes #999.
Changes: