-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AMP #1205
Add AMP #1205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish there was a way to test this, but going over the code it looks fine. I noticed you used cheerio and handlerbars.js, I guess thats fine since it makes it easier to create the AMP pages. https://github.com/cheeriojs/cheerio... has 14k stars and last update 5 months ago, so not too bad to use, but i just hate jquery :)... anyways lgtm, im not as thorough with backend stuff as I am with frontend but the basic template you have in amp_index.hbs
looks fine for me, just kinda wish we could test it somehow. oh well if it breaks, we can always fix it :)
I'm not able to see preview on this post for example: https://busy-master-pr-1205.herokuapp.com/steemit/@aggroed/steem-works-a-funding-mechanism-for-a-worker-proposal-system/amp . I'm testing using this https://search.google.com/test/amp?view=search-preview&id=XB9lHG-FbRpPhSka3bUspQ |
I've clicked on the link you provided and I can see preview: |
@jm90m is the image preview visible for you? |
@jm90m About cheerio:
|
@bonustrack Heres what I see from your link: |
@Sekhmet thanks for the in-depth explanations, makes sense, looks like cheerio was a good choice 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ho! Ok the preview is working actually i just had to switch tab for "Type of result 2".
Fixes #1146
Changes:
ampRender
.head
, select content insidebody
).