Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use yarn #1231

Merged
merged 3 commits into from
Dec 25, 2017
Merged

Use yarn #1231

merged 3 commits into from
Dec 25, 2017

Conversation

Sekhmet
Copy link
Contributor

@Sekhmet Sekhmet commented Dec 22, 2017

DO NOT MERGE

Changes:

  • Use yarn
  • Update code according to eslint (eslint has been updated and it detects some code, that wasn't detected before).

@bonustrack bonustrack temporarily deployed to busy-master-pr-1231 December 22, 2017 21:00 Inactive
@Sekhmet
Copy link
Contributor Author

Sekhmet commented Dec 23, 2017

Can everyone check if this works without problems on their machines?
You can run git fetch origin pull/1231/head:pull-1231 and git checkout pull-1231 to test it with yarn (ideally running dev-server and building client and server).

cc @bonustrack @jm90m @gregory-latinier

@jm90m
Copy link
Contributor

jm90m commented Dec 23, 2017

@Sekhmet works fine for me
screen shot 2017-12-23 at 10 48 53 am

@bonustrack
Copy link
Contributor

Same for me, working well 👍

@Sekhmet
Copy link
Contributor Author

Sekhmet commented Dec 25, 2017

Working fine on Windows 10 with node v8.9.3 and yarn 1.3.2.

@Sekhmet Sekhmet merged commit 8c8e354 into busyorg:master Dec 25, 2017
@Sekhmet Sekhmet deleted the yarn branch December 25, 2017 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sekhmet @jm90m @bonustrack