Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save reward and upvote settings in metadata #1233

Merged
merged 21 commits into from
Dec 25, 2017
Merged

Save reward and upvote settings in metadata #1233

merged 21 commits into from
Dec 25, 2017

Conversation

Sekhmet
Copy link
Contributor

@Sekhmet Sekhmet commented Dec 22, 2017

Fixes #1232

This is continuation of #1141.

Changes:

  • Handle default values for upvoteSetting properly.
  • Fix initialValue for reward's Select.
  • Remove verbose default values.
  • Add test that would have caught upvoteSetting bug.

Kennybll and others added 20 commits November 28, 2017 11:47
@Kennybll
Update For Posted From
e177c1f
@Kennybll
Save reward settings (50%/100% and upvote..) in metadata
3dcf311
@Kennybll
Save reward settings (50%/100% and upvote..) in metadata
05f63e9
@Kennybll
Merge branch 'master' into rewards-upvote-metadata
1d44324
@Kennybll
Merge branch 'master' into rewards-upvote-metadata
727473f
@Kennybll
Merge branch 'master' into rewards-upvote-metadata
256fc5d
@Kennybll
Uses dispatch and adds a constants file.
fe0620b
@Kennybll
Merge branch 'master' into rewards-upvote-metadata
8f3d91b
@Kennybll
Moves constant.js to rewards.js
87d46b5
@Kennybll
Merge branch 'master' into rewards-upvote-metadata
dc8743c
@Kennybll
Merge branch 'master' into rewards-upvote-metadata
ed51f1a
@Kennybll
Merge branch 'master' into rewards-upvote-metadata
a8a58c4
@Kennybll
Merge branch 'master' into rewards-upvote-metadata
b435fd8
@Kennybll
Fix upvote setting not working
61f1601
@Kennybll
Merge branch 'master' into rewards-upvote-metadata
a652cc7
@Sekhmet
Handle upvoteSetting properly and reformat settings reducer
f1d4a55
@Sekhmet
Fix wrong initialValue for reward select
dd3163b
@Sekhmet
Remove verbose defaults
eede760
@Sekhmet
Improve test coverage
cf10a6e 
This adds tests that would have prevented upvoteSetting not to set
to false.
@Sekhmet
Merge branch 'master' into post-settings
9a3d5f7
@Sekhmet Sekhmet added the bug label Dec 22, 2017
@Sekhmet Sekhmet changed the title Post settings Save reward and upvote settings in metadata Dec 22, 2017
@Sekhmet Sekhmet mentioned this pull request Dec 22, 2017
Closed
@Sekhmet Sekhmet modified the milestone: v2.3 Dec 23, 2017
@bonustrack bonustrack temporarily deployed to busy-master-pr-1233 December 24, 2017 13:44 Inactive
bonustrack
bonustrack approved these changes Dec 24, 2017
View reviewed changes
Copy link
Contributor

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well for me

@Sekhmet Sekhmet merged commit 9424046 into busyorg:master Dec 25, 2017
@Sekhmet Sekhmet deleted the post-settings branch December 25, 2017 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack approved these changes

@jm90m jm90m jm90m approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sekhmet @jm90m @bonustrack @Kennybll