Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vote value to user profile #1275

Merged
merged 3 commits into from
Dec 27, 2017
Merged

Add vote value to user profile #1275

merged 3 commits into from
Dec 27, 2017

Conversation

Sekhmet
Copy link
Contributor

@Sekhmet Sekhmet commented Dec 27, 2017

Fixes #1272

image

Changes:

  • Add vote value to user profile.

@bonustrack bonustrack temporarily deployed to busy-master-pr-1275 December 27, 2017 14:47 Inactive
@bonustrack
Copy link
Contributor

When i load the page, $NaN appear for few miliseconds, it should not be the case.
image

@Sekhmet
Copy link
Contributor Author

Sekhmet commented Dec 27, 2017

Should it show 0 as placeholder or hide entire line?

@bonustrack
Copy link
Contributor

The best would be to have a small loading icon, similar than this
image

@Sekhmet
Copy link
Contributor Author

Sekhmet commented Dec 27, 2017

Loading icon instead of entire line or to replace $ icon? If the latter what should the value be?

@bonustrack
Copy link
Contributor

I would see the line loading like this:
$ Vote value: [loading-icon]

bonustrack
bonustrack approved these changes Dec 27, 2017
View reviewed changes
Copy link
Contributor

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@Sekhmet Sekhmet merged commit b254962 into busyorg:master Dec 27, 2017
@Sekhmet Sekhmet deleted the voting-value branch December 27, 2017 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack approved these changes

@jm90m jm90m Awaiting requested review from jm90m

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sekhmet @bonustrack