Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability with slow internet #1621

Merged
merged 2 commits into from
Mar 11, 2018
Merged

Conversation

kirkins
Copy link
Contributor

@kirkins kirkins commented Mar 9, 2018

I'm having an issue that sounds similar to #1576.

Unfortunately my internet is slow right now.

This has led to find that both Busy client and server have a maximum timeout of 5 seconds.

screenshot from 2018-03-08 19-05-17

Related issue for rpc.

@kirkins kirkins changed the title WIP: Busy Usability, rural internet & developing countries WIP: Usability with slow internet Mar 9, 2018
@Sekhmet
Copy link
Contributor

Sekhmet commented Mar 9, 2018

We for sure don't want to increase the timeout on the server to 15 seconds (as it will cause a request to take up to 15 seconds to finish).

@kirkins
Copy link
Contributor Author

kirkins commented Mar 9, 2018

@Sekhmet if it is "up to 15 seconds" I think that is fine for anyone with slow Internet.

If it is minimum 15 seconds that will be a problem. Is this maximum 15 seconds or minimum?

The problem with 5 seconds is that busy.org becomes completely unusable for anyone with a slow internet connection. If I switch to Steemit.com instead on slow internet it takes a while, over 5 seconds but it eventually loads.

With this current timeout Busy just says if you can't load a request in 5 seconds you can't use the site.

There are a lot of people using Steem in developing countries so I'm sure this issue is extremely common.

@Sekhmet
Copy link
Contributor

Sekhmet commented Mar 9, 2018

Let's say api.steemit.com has some problem and won't finish request that we make on the server -> user is waiting for 15 seconds for Busy.org to respond.
Client timeout can be changed, but I don't think we should keep hundreds of open connections on the server, just because we are waiting for API to suddenly come back to life.

@kirkins
Copy link
Contributor Author

kirkins commented Mar 9, 2018

@Sekhmet I see the server part is just concerning communication between Busy and Steem API?

I didn't realize that, I'll have to do some more testing. The PR as it is now doesn't improve the situation for me at all.

@Sekhmet
Copy link
Contributor

Sekhmet commented Mar 9, 2018

If you want to change timeout on the client only you can do it here:

const client = createClient(process.env.STEEMJS_URL || 'https://api.steemit.com');

@kirkins
Copy link
Contributor Author

kirkins commented Mar 9, 2018

@Sekhmet thanks, that fixes it for me.

Note: deleted original 2 commits.

@bonustrack bonustrack changed the title WIP: Usability with slow internet Usability with slow internet Mar 11, 2018
Copy link
Contributor

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, seem to be working well now 👍

@Sekhmet Sekhmet merged commit 14a3421 into busyorg:master Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants