Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] show powerdown information in wallet #2147

Merged
merged 5 commits into from
Jan 22, 2019

Conversation

economicstudio
Copy link
Collaborator

Changes

  • Show the powerdown amount in the wallet
  • Show the tooltip with next powerdown(withdrawal) date

Test plan

Explain how to test changes you made.

  • Pick a user powering down to check powerdown information is shown
  • Pick another user not powering down to check powerdown information is not shown.

Demo

Currently, Busy shows nothing!

After, Busy shows both powerdown and delegation in a compact form.

Benefits

Given that most users are not familiar with steemd.com or at least not using it daily basis, widely used UIs should show sufficient powerdown information. There are several benefits.

  1. Hacking prevention
    There are many cases where hackers start the powerdown and victims even don't recognize it! If the information is properly shown, this hacking can be prevented.

  2. Correct vote value
    It can also prevent a bug of incorrect vote value. Even if the vote value is shown correctly, e.g., steempeak, users may wonder why their vote value is quite low. Note that around the end of 13 weeks of powerdown, the difference can be huge. In Ned's case, it's almost twice, and much more than twice next week.

  3. Stopping powerdown
    In addition, users powering down may change their mind to stop the powerdown if the information is clearly shown everyday. Especially when it's almost done (again, for instance, Ned), the powerdown amount is quite big compared to the remaining so the chance of changing their mind might be pretty high :)

@Sekhmet
Copy link
Contributor

Sekhmet commented Jan 17, 2019

Maybe we should display three rows:

  • Steem Power
  • Delegated Steem Power
  • Powering down Steem Power
    We could hide last two if they are equals to 0.

@economicstudio
Copy link
Collaborator Author

Currently when they're zero, they are hidden, so I think that's fine. I also considered three-line representation, but here are some reasons why I didn't do:

  1. One line might be actually more meaningful in terms of voting value, since that net amount is actual effective SP for vote value
  2. Which icon I should use for the other two :) Maybe without icons might be fine.

If you prefer 3 rows, let me know then I'll make a change. Thanks!

@Sekhmet Sekhmet requested a deployment to busy-develop-pr-2147 January 22, 2019 16:22 Abandoned
Copy link
Contributor

@Sekhmet Sekhmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature might be useful because of recent events, so we can release it as-is and later we might think about finding an alternative way to display this information.
Thanks.

@Sekhmet Sekhmet merged commit 4565931 into busyorg:develop Jan 22, 2019
@economicstudio
Copy link
Collaborator Author

economicstudio commented Jan 23, 2019

@Sekhmet Thanks for merging. Due to steemit/steem#3237 PR #2160 is needed to fix #2159 for 14-week powerdown users. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants