fix-reblogged-by #2150
Merged
fix-reblogged-by #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
post.first_reblogged_by returns null. should use post.reblogged_by https://github.com/steemit/condenser/blob/7430aca58ae9f86e501f52e3cf8dba5efc9fe3e0/src/app/components/cards/PostSummary.jsx#L70 In addition, to show 'reblogged' in blog (not feed), the current code should be changed. Currently there is no easy way to differentiate if it's feed or blog. But any resteemed post in a blog is easily noticeable by author's name, so not important as reblogged_by in feed.
|
@economicstudio |
|
Thanks for your approval and I made it (and all others) editable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2149
Changes
post.first_reblogged_byreturns null.post.reblogged_byshould be used as follows:https://github.com/steemit/condenser/blob/7430aca58ae9f86e501f52e3cf8dba5efc9fe3e0/src/app/components/cards/PostSummary.jsx#L70
Test plan
Explain how to test changes you made.
Demo
In addition, to show 'reblogged' in blog (not feed), the current code should be changed. Currently there is no easy way to differentiate if it's feed or blog. But any resteemed post in a blog is easily noticeable by author's name, so not important as reblogged_by in feed.