Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server side rendering #449

Merged
merged 31 commits into from
Apr 27, 2017
Merged

Server side rendering #449

merged 31 commits into from
Apr 27, 2017

Conversation

nil1511
Copy link
Contributor

@nil1511 nil1511 commented Apr 3, 2017

Currently, It is doing server-side rendering for post only. For feeds and users page actions need to changes to be promisable and work with route. For other pages, this can be broken into different PR.

@nil1511 nil1511 added the PR: WIP label Apr 3, 2017
@bonustrack bonustrack temporarily deployed to busy6-pr-449 April 3, 2017 16:44 Inactive
@bonustrack bonustrack temporarily deployed to busy6-pr-449 April 4, 2017 13:06 Inactive
@bonustrack bonustrack temporarily deployed to busy6-pr-449 April 4, 2017 17:51 Inactive
@bonustrack bonustrack temporarily deployed to busy6-pr-449 April 11, 2017 02:38 Inactive
@nil1511 nil1511 temporarily deployed to busy6-pr-449 April 19, 2017 10:58 Inactive
@nil1511 nil1511 temporarily deployed to busy6-pr-449 April 19, 2017 11:51 Inactive
@nil1511 nil1511 temporarily deployed to busy6-pr-449 April 19, 2017 12:11 Inactive
@nil1511
Copy link
Contributor Author

nil1511 commented Apr 19, 2017

@adcpm can you check now?
Sidebar is not loading because it is not using redux state.
Server rendering is working only post as of now So we should not remove title and description meta.

@bonustrack
Copy link
Contributor

I try to share on Facebook and findout it doesnt link to busy but to steemit. Issue is og:url, it should always be busy.org, it's not same as canonical.

@bonustrack
Copy link
Contributor

Also can you add " - Busy" on the end of article title?

@nil1511 nil1511 temporarily deployed to busy6-pr-449 April 20, 2017 16:06 Inactive
@bonustrack
Copy link
Contributor

Hum. For some reason, sharing on Facebook would not show image & description anymore.
image
Strange because that was not the case on last deployment. Something that may cause this is that we have actually 2 <title> tag:
image

@bonustrack
Copy link
Contributor

Maybe Facebook create image and description based on the URL of og:url.

@nil1511
Copy link
Contributor Author

nil1511 commented Apr 20, 2017

yes that can be.
should we try with pr app url as og:url prefix?

@bonustrack
Copy link
Contributor

You can make that og:url use the current url origin.

@nil1511
Copy link
Contributor Author

nil1511 commented Apr 20, 2017

Updated. Now it is working.

@nil1511
Copy link
Contributor Author

nil1511 commented Apr 20, 2017

The method of setting origin now(using global) is not good. we should eventually switch to env variable in future.

@p0o p0o merged commit 89d2519 into dev Apr 27, 2017
@nil1511 nil1511 deleted the server-side-rendering branch May 4, 2017 06:37
@nil1511 nil1511 restored the server-side-rendering branch May 4, 2017 06:37
@bonustrack bonustrack deleted the server-side-rendering branch June 10, 2017 11:26
@bonustrack bonustrack mentioned this pull request Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants