Update TopicSelector styles #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes how TopicSelector behaves on smaller screens. - TopicSelector items are now aligned in center - "Sort by" and current sort now have white-space set to nowrap to prevent breaking it. - "Sort by" and current sort now have display set to inline-block to cause them to split to two lines if there is no room.
jm90m
reviewed
Nov 3, 2017
src/components/TopicSelector.less
Outdated
| @@ -20,11 +21,18 @@ | |||
|
|
|||
| &__sort { | |||
| color: #99aab5; | |||
| text-align: right; | |||
|
|
|||
| span:first-of-type { | |||
There was a problem hiding this comment.
Would it be better to use a className here rather than selecting the first span? Maybe use &__label for className="TopicSelector__sort__label" or className="TopicSelector__sort__title" or something else similar?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #988.
This changes how TopicSelector behaves on smaller screens.
breaking it.
cause them to split to two lines if there is no room.
Before:
After: