Add babel-polyfill #993
Merged
Add babel-polyfill #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jm90m
reviewed
Nov 3, 2017
| process.env.STEEMCONNECT_CLIENT_ID | ||
| && process.env.STEEMCONNECT_REDIRECT_URL | ||
| && process.env.STEEMCONNECT_HOST | ||
| process.env.STEEMCONNECT_CLIENT_ID && |
There was a problem hiding this comment.
I see prettier autoformatted this file 🤣
There was a problem hiding this comment.
I'm not sure if it's a bad thing. We have to reformat files at some point.
|
this looks fine to me, I use a mac so I can't test unless I dual boot / use remote desktop. Everyone should just switch to chrome / firefox anyways when you're dealing with crypto websites that hold sensitive information |
jm90m
approved these changes
Nov 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #845
This solves problem with Busy not working in IE11. It works on production builds, not on development builds.
Supporting IE < 11 is more problematic, because of the lack of Web Cryptography API. I don't think we should try to make it work on IE 10 and below as it is not used anymore, insecure and using polyfills for something as important as cryptography might introduce vulnerabilities.
Changes:
babel-polyfillto the entry of the app.