Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carthage support #134

Merged
merged 8 commits into from Aug 10, 2017
Merged

Carthage support #134

merged 8 commits into from Aug 10, 2017

Conversation

edwardaux
Copy link
Contributor

I'd love to be able to add Carthage support. I notice that there was a previous PR (#120) that seems to have stalled. Not sure if that is because the changes are not acceptable, or just look intimidating due to the xcodeproj file format.

Anyway, this PR is slightly less large as it doesn't play with the umbrella header or the module map. I've also been very deliberate in how I've broken the commits up so you can see the specific changes that have been made along the way. Specifically, this is what I did:

  • Added a new Objective-C Cocoa Touch Framework target called DeepLinkKit
  • When you do the above, it creates a new group in the navigator called DeepLinkKit with a new file called Info.plist and a reference to the existing DeepLinkKit.h. All I did was move the reference to Info.plist into the existing group of the same name, remove the duplicate reference to the .h file, and remove the duplicate group. Purely housekeeping to make the navigator look neat.
  • I then selected all the .m files and added them to the newly created target
  • Next, I grabbed all of the public .h files referenced in the DeepLinkKit.h umbrella header and made sure they were marked as public so they get copied into the DeepLinkKit.framework/Headers folder
  • Removed an empty build phase step that gets added when you create the target
  • Marked the scheme as public so that Carthage will find and compile
  • Updated the install instructions to contain some instructions on how to use Carthage

So, even though the project.pbxproj has loads of changes, hopefully you can see from the above, they are pretty contained.

@button-bot
Copy link

Hi @edwardaux,
Thank you for your Pull Request!

It looks like you haven't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen license.
Wikipedia

Please read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to let us know.

Thank you,

ButtonBot

@edwardaux
Copy link
Contributor Author

edwardaux commented Aug 10, 2017

Have signed contributor license.

[clabot:check]

@chrismaddern
Copy link
Contributor

Nice @edwardaux! We’ll take a look quickly and try to get this merged! 😄😄

@wessmith wessmith self-requested a review August 10, 2017 20:06
@wessmith
Copy link
Member

Thanks @edwardaux! This looks great–really appreciate the thoroughness!

fixes #120

@wessmith wessmith mentioned this pull request Aug 10, 2017
@wessmith wessmith merged commit b999528 into button:master Aug 10, 2017
@edwardaux edwardaux deleted the carthage-support branch August 10, 2017 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants