Changes needed for iOS support #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nges from 10363f1..903ed4f 903ed4f Merge commit 'f73e040957c02b14e5ab79bbb32c2807fba148cc' into cli-installer 890e3b9 feat: Adding more LiBo devices f73e040 build: Create special build command for CI 9a06640 build: More fixing of artifact uploading 25128a6 build: Fix artifact output for azure ed226b9 Try using a completely blank counter 305b504 Don't name counter variable, as it's not dependent on anything to reset a771a49 Fix variable map for azure 3660584 Add Pipelines files for doing automated releases git-subtree-dir: packages/buttplug/dependencies/buttplug-device-config git-subtree-split: 903ed4f519d4c432a6994b30d7c244129c179d4c
There's a iOS app called "WebBLE" that's basically the in-app browser with a bluetooth polyfill. It's missing a lot of functionality, so if we want to support it, it requires some workarounds. - getPrimaryServices is now GetPrimaryService, which is cleaner anyways. - If a device requires getCharacteristics() and it's not available (as it is missing in the polyfill), just say we can't connect to the device at all. This shouldn't happen except for devices with no characteristic definitions.
We used to be able to discover these, but if we want to work on iOS, we require the characteristics to be explicitly defined due to missing polyfill. Sadness.
Turns out our test code wasn't properly tested, so switching lovense devices over to non-characteristic-discovery-mode caused all web bluetooth tests to break.
They don't need to be anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change a few WebBluetooth calls that aren't supported in the iOS polyfill, and fill in device values from lovense.