feat: Adding multiple device protocols #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a copy of the config in the C# PR, so this commit will probably need to be rebased out for the subtree pull.
This change ports missing protcols from C# to JS: * LiBo/Sistalk * MagicMotion (fixes buttplugio#114) * Youcups (fixes buttplugio#117) * Vorze Bach
|
This merged to dev today, but I brought it in with the Kiiroo 2 commit that didn't even have a PR yet. The main problem now is that the device configs don't match. I'll pull the device config from your repo, diff it and create a patch out of that, as the PR over in the device-config repo also doesn't match the one here (is missing the MonsterPub and stuff). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ports missing protocols from C# to JS:
There's something odd with the device-config not merging nicely, but I think that should be corrected elsewhere and the change in this PR rebased out.
Still need to write tests too.