-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship as part of GitLab #265
Comments
@dosire it's probably best for your users. Just to be clear, what do you mean by shipping Octotree as part of GitLab, are you going to implement the tree from scratch or taking bits and pieces from Octotree? |
@buunguyen I'm thinking about reusing as much of Octotree as we can and contributing back any fixes we make in its code. |
Got that. Unless a change is non-GitLab specific, I don't think contributing back is necessary as there's no reason to keep GitLab support in Octotree if the feature is built-in. @crashbell and I myself spent many months working on and off to bring GitLab support to Octotree. It's a bit sad that we can't enjoy the fruit of our labor a bit longer ;). But I guess this is best for the community and I'm glad our work helps improve GitLab. |
@buunguyen I agree that only generic changes would make sense to contribute back. I'm sorry that integrating it would negate your and @crashbell's work on it. Obviously we really happy that there is support right now. And I'm not sure if and when we'll add support in GitLab itself, but I wanted your blessing before proceeding, thanks. Can I make you both happy with some GitLab swag? |
Link back to GitLab issue https://gitlab.com/gitlab-org/gitlab-ce/issues/13723 |
@crashbell may chime in here but I don't think he would object. Please go ahead. |
Thanks @buunguyen |
So, they are not shipping Octotree but they are integrating VSCode: https://gitlab.com/gitlab-org/gitlab-ce/issues/31890 Near the end of the first issue, we discover a similar project: https://github.com/git-toni/reposplit (Chrome only ATM, Gitlab support but no private Gitlab projects) |
I've just found an extension working very well for gitlab (work for self hosted): https://chrome.google.com/webstore/detail/gitlab-code-view/gglalfcdiahpedikbmegmmkmpmajnpjj |
Hi Buu,
Are you open to having us ship octotree as part of GitLab? This would help with usage:
Obviously we would do all the work of integrating this and we would contribute back any fixes that are relevant.
What do you think? Please let me know if you prefer to talk about this.
The text was updated successfully, but these errors were encountered: