Fix: rough scroll on expanded #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, and I love deleting code. 🙂 I'll merge it in once it's rebased on master. (But I'll probably merge #577 in first, so don't rebase this until that one lands… 😉) |
ericawright
force-pushed
the
rough-scroll
branch
from
9b80e65 to
7fab8fa
Compare
|
rebased |
…tore overflow attribute in order to use it.
|
I believe this could eventually fix other scrolling and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reviewer @bwinton
remove scroll method in favor of built-in arrowscrollbox method.
restore overflow attribute in order to use said method.
Fixes: #273.
Fixes: #492.