Add Forum settings to Channel struct #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedorLap2006
requested changes
Dec 25, 2022
There was a problem hiding this comment.
Thank you for the PR! Here's some of my thoughts on it:
- We usually prefix the constant values of various types, to allow for better discoverability.
Channelstructure is only used for retrieving data from the API. The fields might also need to be added intoChannelEditstructure, to allow for usage inModifyendpoint. They should haveomitempty, and if necessary, pointer type. If a field has a possiblenullvalue, just leave a "nullable" TODO, and keep it a pointer.
FedorLap2006
requested changes
Dec 31, 2022
|
Sorry for reviewing it at such a time. Kinda forgot about the PR in all the holiday stuff. |
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
|
In my area, the New Year has come a little earlier. |
|
Thank you for a quick response, I'll probably merge the PR on the week. |
FedorLap2006
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some settings of forum channel as shown docs.
https://discord.com/developers/docs/change-log#add-default-layout-setting-for-forum-channels
https://discord.com/developers/docs/change-log#default-sort-order-for-forum-channels
https://discord.com/developers/docs/resources/channel#channel-object-channel-structure