Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Role tracking. Support disabling individual features in state. Closes #195. #196

Merged
merged 1 commit into from
May 8, 2016
Merged

Conversation

iopred
Copy link
Collaborator

@iopred iopred commented May 8, 2016

No description provided.

@iopred iopred changed the title Add Role tracking. Support disabling individual features in state. Add Role tracking. Support disabling individual features in state. Closes #195. May 8, 2016
@bwmarrin
Copy link
Owner

bwmarrin commented May 8, 2016

What do you think about using a bitmask int to enable/disable options vs bools?

@bwmarrin bwmarrin added this to the v0.13.0 milestone May 8, 2016
@bwmarrin bwmarrin added the feature Major feature implementation label May 8, 2016
@iopred
Copy link
Collaborator Author

iopred commented May 8, 2016

Generally I think that matters when you need to transmit the data, in this
case it'll add complexity for no gain. (Like less bandwidth etc.)
On May 8, 2016 1:13 PM, "Bruce" notifications@github.com wrote:

What do you think about using a bitmask int to enable/disable options vs
bools?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#196 (comment)

@bwmarrin
Copy link
Owner

bwmarrin commented May 8, 2016

Fair enough. :)

@bwmarrin bwmarrin merged commit 1d2d93a into bwmarrin:develop May 8, 2016
alex-j-butler pushed a commit to alex-j-butler/discordgo that referenced this pull request Nov 5, 2016
Add Role tracking. Support disabling individual features in state. Closes bwmarrin#195.
@iopred iopred deleted the stateroles branch December 10, 2016 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Major feature implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants