This repository has been archived by the owner on Mar 25, 2023. It is now read-only.
feat(select account) - use ngrx for selected account #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/app/shared/shared.module.ts # src/app/spare-drive/spare-drive-filter/spare-drive-filter.component.ts # src/app/vm/vm-filter/vm-filter.component.ts
# Conflicts: # src/app/shared/shared.module.ts
# Conflicts: # src/app/vm/vm-creation/vm-creation.component.ts
# Conflicts: # src/app/account/accounts.module.ts # src/app/accounts/redux/accounts.effects.ts
# Conflicts: # src/app/account/account-page/account-page.component.html # src/app/account/account-sidebar/account-details/account-details.component.ts # src/app/account/account-sidebar/account-limits/account-limits.component.ts # src/app/account/account-sidebar/account-sidebar.component.html # src/app/account/account-sidebar/account-statistic/account-statistics.component.ts
zolotyx
suggested changes
Oct 20, 2017
| @@ -18,11 +17,8 @@ export class ResourceCountService extends BaseBackendCachedService<ResourceCount | |||
| } | |||
|
|
|||
| public updateResourceCount( | |||
| account: Account | |||
| params: any | |||
| state => state.loading | ||
| ); | ||
|
|
||
| export const configurations = createSelector( |
| state => state.loading | ||
| ); | ||
|
|
||
| export const domians = createSelector( |
| state => state.loading | ||
| ); | ||
|
|
||
| export const resourceCounts = createSelector( |
| state => state.loading | ||
| ); | ||
|
|
||
| export const resourceLimits = createSelector( |
| state => state.loading | ||
| ); | ||
|
|
||
| export const roles = createSelector( |
# Conflicts: # src/app/account/account-container/account.container.ts
zolotyx
suggested changes
Oct 23, 2017
| } | ||
|
|
||
| public onConfigurationEdit(configuration) { | ||
| this.account$ |
There was a problem hiding this comment.
Please, get rid of this and the following subscribes
| (onAccountChanged)="onAccountChange($event)" | ||
| ></cs-account-sidebar>` | ||
| }) | ||
| export class AccountSidebarContainerComponent extends WithUnsubscribe() implements OnInit { |
| <div *ngFor="let limit of limits" class="height-container"> | ||
|
|
||
|
|
||
| <div *ngIf="!isEdit"> |
# Conflicts: # src/app/reducers/domains/redux/domains.reducers.ts # src/app/ssh-keys/containers/ssh-key-list.container.ts
zolotyx
suggested changes
Oct 24, 2017
zolotyx
approved these changes
Oct 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#597