Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

feat: Add extending faker by custom providers #33

Merged
merged 2 commits into from
Sep 18, 2018

Conversation

rodnover55
Copy link
Contributor

Hello. This pull request added ability to add new tag in faker with custom providers. Existing tag cannot be rewritten

@codecov
Copy link

codecov bot commented Aug 22, 2018

Codecov Report

Merging #33 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   97.85%   97.88%   +0.02%     
==========================================
  Files           8        8              
  Lines         373      378       +5     
==========================================
+ Hits          365      370       +5     
  Misses          4        4              
  Partials        4        4
Impacted Files Coverage Δ
faker.go 95.45% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75df739...2e7aba6. Read the comment docs.

@bxcodec
Copy link
Owner

bxcodec commented Aug 31, 2018

Very cool,

I'm curious, is this will work. I mean, if we import this package in another package, how to use it anyway?

If you don't mind, add some example how to use it in readme.md

@rodnover55
Copy link
Contributor Author

As I see it works correctly.

I test it with this code.
Could you review example to be make sure that I tested what you want?

If all is ok, I will change readme. ;)

Thank you.

Copy link
Owner

@bxcodec bxcodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bxcodec bxcodec merged commit 41c1be6 into bxcodec:master Sep 18, 2018
@bxcodec bxcodec changed the title Add extending faker by custom providers feat: Add extending faker by custom providers Sep 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants