Skip to content

Conversation

Cluas
Copy link
Contributor

@Cluas Cluas commented May 12, 2022

compatible with pg 10 trigger event syntax.

https://www.postgresql.org/docs/10/sql-createeventtrigger.html

@Cluas Cluas requested a review from d-bytebase as a code owner May 12, 2022 15:21
@cla-bot
Copy link

cla-bot bot commented May 12, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Cluas.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@Cluas Cluas force-pushed the feat-dump_suppport_pg_10 branch from 70c1ede to 3547aa5 Compare May 12, 2022 15:24
@cla-bot cla-bot bot added the cla-signed label May 12, 2022
@Cluas Cluas requested a review from dragonly May 12, 2022 15:29
Copy link
Collaborator

@d-bytebase d-bytebase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG otherwise, thanks!

@Cluas Cluas requested a review from d-bytebase May 12, 2022 15:45
dragonly
dragonly previously approved these changes May 12, 2022
Copy link
Contributor

@dragonly dragonly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG otherwise.

d-bytebase
d-bytebase previously approved these changes May 12, 2022
Copy link
Collaborator

@d-bytebase d-bytebase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@Cluas Cluas dismissed stale reviews from d-bytebase and dragonly via 69c66e0 May 12, 2022 15:53
d-bytebase
d-bytebase previously approved these changes May 12, 2022
@Cluas Cluas requested a review from tianzhou May 12, 2022 15:59
@Cluas Cluas changed the title feat: compatible with pg 10 syntax feat: compatible with pg 10 PROCEDURE syntax May 12, 2022
@Cluas Cluas changed the title feat: compatible with pg 10 PROCEDURE syntax feat: dump support pg 10 PROCEDURE syntax May 12, 2022
@Cluas Cluas changed the title feat: dump support pg 10 PROCEDURE syntax feat: dump support PROCEDURE syntax May 12, 2022
@Cluas Cluas changed the title feat: dump support PROCEDURE syntax feat: dump schema support PROCEDURE syntax May 12, 2022
tianzhou
tianzhou previously approved these changes May 12, 2022
Copy link
Collaborator

@tianzhou tianzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dragonly
Copy link
Contributor

Is it possible to argue that within the valid version, only 10 is special

@Cluas
https://www.postgresql.org/support/versioning/

The PostgreSQL Global Development Group supports a major version for 5 years after its initial release. After its five year anniversary, a major version will have one last minor release containing any fixes and will be considered end-of-life (EOL) and no longer supported.

IMO, the "unsupported version" refers to an end-of-life version, but the doc is still valid for that version.

@Cluas
Copy link
Contributor Author

Cluas commented May 12, 2022

Is it possible to argue that within the valid version, only 10 is special

@Cluas https://www.postgresql.org/support/versioning/

The PostgreSQL Global Development Group supports a major version for 5 years after its initial release. After its five year anniversary, a major version will have one last minor release containing any fixes and will be considered end-of-life (EOL) and no longer supported.

IMO, the "unsupported version" refers to an end-of-life version, but the doc is still valid for that version.

Thanks for the science, then indeed this should be <=10

@dragonly
Copy link
Contributor

dragonly commented May 12, 2022

then indeed this should be <=10

But as is mentioned by @tianzhou here

As a 2nd thought. I am with your original proposal to limit to 10 for now. It's more prudent to limit the scope and expand later if we do need to.

@Cluas Maybe it's good to just support 10 because you can test it. We are not testing other versions anyway.

Copy link
Collaborator

@tianzhou tianzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d-bytebase d-bytebase merged commit b7043a5 into bytebase:main May 12, 2022
RainbowDashy pushed a commit to RainbowDashy/bytebase that referenced this pull request May 17, 2022
* feat: compatible with pg 10 syntax

* feat: parse version

* fix: unchange

* fix: false

* docs: add description doc

* docs: update comment

* feat: limit 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants