-
Notifications
You must be signed in to change notification settings - Fork 841
feat: dump schema support PROCEDURE syntax #1291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Cluas.
|
70c1ede
to
3547aa5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG otherwise, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Cluas
IMO, the "unsupported version" refers to an end-of-life version, but the doc is still valid for that version. |
Thanks for the science, then indeed this should be <=10 |
But as is mentioned by @tianzhou here
@Cluas Maybe it's good to just support 10 because you can test it. We are not testing other versions anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: compatible with pg 10 syntax * feat: parse version * fix: unchange * fix: false * docs: add description doc * docs: update comment * feat: limit 10
compatible with pg 10 trigger event syntax.
https://www.postgresql.org/docs/10/sql-createeventtrigger.html