Skip to content

chore: make config name more verbose #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

chore: make config name more verbose #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/chatops-migrate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ jobs:
targets: ${{ steps.parse.outputs.targets }}
steps:
- name: Write command config
# write a config.yaml file to runner temp directory
# write a bytebase-action-config.yaml file to runner temp directory
run: |
cat <<EOF > ${{ runner.temp }}/config.yaml
cat <<EOF > ${{ runner.temp }}/bytebase-action-config.yaml
test:
stage: environments/test
targets:
Expand All @@ -40,7 +40,7 @@ jobs:
COMMENT="${{ github.event.comment.body }}"
echo "Comment: $COMMENT"

CONFIG_FILE="${{ runner.temp }}/config.yaml"
CONFIG_FILE="${{ runner.temp }}/bytebase-action-config.yaml"

# Get list of valid environments from config
VALID_ENVS=$(yq eval 'keys | join(", ")' "$CONFIG_FILE")
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ This workflow enables ChatOps-style deployments through PR comments. Team member

#### Configuration

1. **Define environments in the workflow**: Edit the `config.yaml` generation step to define your environments and their database targets.
1. **Define environments in the workflow**: Edit the `bytebase-action-config.yaml` generation step to define your environments and their database targets.

> [!NOTE]
> The top-level keys (e.g., `test`, `prod`) are used as GitHub Actions job environments, so they must match the environment names configured in your repository settings.
Expand All @@ -81,7 +81,7 @@ This workflow enables ChatOps-style deployments through PR comments. Team member
```yml
- name: Write command config
run: |
cat <<EOF > ${{ runner.temp }}/config.yaml
cat <<EOF > ${{ runner.temp }}/bytebase-action-config.yaml
test:
stage: environments/test
targets:
Expand Down