Skip to content

Conversation

dipankardas011
Copy link
Contributor

@dipankardas011 dipankardas011 commented Jun 9, 2024

Task description

patch for commands used to wasm-bindgen and wasm-tools

Copy link
Collaborator

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@rylev
Copy link
Collaborator

rylev commented Jun 10, 2024

@dipankardas011 is there a reason this PR is marked as a draft?

@dipankardas011
Copy link
Contributor Author

@dipankardas011 is there a reason this PR is marked as a draft?

Actually I am trying the tinygo wasip2 so once I have read completely I will make it open

wasm-bindgen and wasm-tools commands

Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
@dipankardas011 dipankardas011 force-pushed the fix-tinygo-wasip2-docs branch from 9053cbb to 784b95e Compare June 11, 2024 04:15
@dipankardas011 dipankardas011 changed the title patch: for tinygo wasip2 support [WIP] patch: for tinygo wasip2 support Jun 11, 2024
@dipankardas011 dipankardas011 marked this pull request as ready for review June 11, 2024 04:17
@dipankardas011
Copy link
Contributor Author

dipankardas011 commented Jun 11, 2024

Finalised the PR

@itowlson itowlson requested a review from kate-goldenring June 11, 2024 21:04
Copy link
Collaborator

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching these @dipankardas011

@kate-goldenring kate-goldenring merged commit d6eda9e into bytecodealliance:main Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants