-
Notifications
You must be signed in to change notification settings - Fork 70
fix: use adder interface for host #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use adder interface for host #192
Conversation
@vados-cosmonic many of the language guides reference this example world ( |
Hey @kate-goldenring thanks for the catch -- I was under the impression that most guides were using the At this point, guides like the C# guide actually explicitly use/take into account the lack of an interface (and later show you how to build an adder via interfaces) -- it looks like With the goal of centralizing the WIT to a single place and away from host code, what do you think about |
@vados-cosmonic i'd rather move everything to the The c guide takes into account the lack of interface because our example has no interface not because it should -- I'd rather it does not discuss using worlds that don't use interfaces as it is a best practice to use interfaces IMO. |
Alright, that sounds good -- we'll knock out #24 as well at the same time in this PR!
Absolutely agree here -- while the simple function case might be good for simplicity (less new keywords mentioned, etc), the best practice is definitely using interfaces. |
@vados-cosmonic just a check on this, i know it is a lot of updates. I can also help take some of this on as well. Would be great to get rid of the interface-less add.wit interface and only use the adder world |
Hey thanks for the ping -- I got busy and forgot about this -- need to get back to it! I'll find time to wrap this up by next week! |
a3af44b
to
19bc006
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @vados-cosmonic. I left a few nits that could be addressed in this PR or a subsequent one
e5af4f9
to
6322c17
Compare
Hey @kate-goldenring finally this is done and I think mergable! It should merge after James's awesome work here: #221 (I already merged his changes in actually but just don't want to "steal" his hard work!) Definitely happy to follow with follow ups as well if you find anything I missed -- I went through all the guides for all the languages and they all worked just fine. There may be some step numbering issues (I introduced step numbering where there wasn't for many of the guides). |
@vados-cosmonic sounds good! Can you rebase and we should be set to merge? |
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
7d9657a
to
12b0eeb
Compare
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Hey @kate-goldenring apologies for the delay here -- should be good to go! |
This PR updates the host to use the existing
adder
interface, and actually re-use the existing WIT file so it should be harder to diverge in the future.Resolves #24