Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: define export as typescript interface #50

Merged
merged 2 commits into from
Mar 20, 2023
Merged

fix: define export as typescript interface #50

merged 2 commits into from
Mar 20, 2023

Conversation

eduardomourar
Copy link
Contributor

@eduardomourar eduardomourar commented Mar 20, 2023 •
edited
Loading

Following the same approach used in #30, we will use a TypeScript interface in the WASI exports.

guybedford
guybedford approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, can you just run rust fmt for the CI to pass?

@eduardomourar eduardomourar force-pushed the fix/define-export-interface branch from ef66c1d to b24b258 Compare March 20, 2023 20:19
@eduardomourar eduardomourar marked this pull request as ready for review March 20, 2023 20:20
@eduardomourar eduardomourar changed the title fix: define export interface fix: define export as typescript interface Mar 20, 2023
@guybedford guybedford merged commit b9c1ce4 into bytecodealliance:main Mar 20, 2023
@eduardomourar eduardomourar deleted the fix/define-export-interface branch March 20, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guybedford guybedford guybedford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eduardomourar @guybedford