Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm the AF3 typo #8

Open
v-shaoningli opened this issue Nov 11, 2024 · 1 comment
Open

Confirm the AF3 typo #8

v-shaoningli opened this issue Nov 11, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@v-shaoningli
Copy link

v-shaoningli commented Nov 11, 2024 •
edited
Loading

Hi ALL. I've confirmed the typo reported in your techinical report with AF3's code:

image

Algorithm 1 Line 10

Algorithm 3 Line 8

Algorithm 18 Line 9

Algorithm 23 Line 2

Algorithm 31 Line 3

We cannot confirm weighted rigid align and diffusion loss weight now but we think the modifications in your technical report are right.

Best,
Shaoning
@zhangyuxuann
Copy link
Collaborator

Hi @v-shaoningli, thank you very much! :)

@zhangyuxuann zhangyuxuann added good first issue Good for newcomers documentation Improvements or additions to documentation and removed good first issue Good for newcomers labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhangyuxuann @v-shaoningli