Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Runtime]Add runtime dynamic shared mem support #179

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Runtime]Add runtime dynamic shared mem support #179

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
635c81b
add dynamic shared mem support
Mar 26, 2024
d16f1e9
Merge remote-tracking branch 'upstream/main' into support_dynamic_sha…
Apr 2, 2024
b27ce87
Merge remote-tracking branch 'upstream/main' into support_dynamic_sha…
Apr 2, 2024
0caf93e
clang formaty
Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion runtime/lib/backends/cuda/providers/default/codegen/ptx.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ using namespace mlir;
#define BLOCK_SIZE_X_ATTR "BlockSize.x"
#define BLOCK_SIZE_Y_ATTR "BlockSize.y"
#define BLOCK_SIZE_Z_ATTR "BlockSize.z"
#define SHARED_MEMORY_SIZE "DynamicSharedMemorySize"
#define ARG_RANKS_ATTR "arg_ranks"
#define CALL_CONVENTION_ATTR "call_convention"

Expand Down Expand Up @@ -92,6 +93,11 @@ struct PTXImpl {
CUfunction func;
auto status_func = ptx_compiler->GetOrCreateFunction(
func, kernel_info.kernel_name, kernel_info.file_name);
size_t max_shared_mem = 48 << 10;
if (shared_size > max_shared_mem) {
cuFuncSetAttribute(func, CU_FUNC_ATTRIBUTE_MAX_DYNAMIC_SHARED_SIZE_BYTES,
shared_size);
}
BRT_ENFORCE(status_func.IsOK(), status_func.ErrorMessage());
device2func.emplace(device_id, func);
return func;
Expand Down Expand Up @@ -170,11 +176,17 @@ PTXOpKernel::PTXOpKernel(const OpKernelInfo &info)
ranks.push_back(GetRankFromOpArgIndex(info_, i));
}
}
int64_t dynamic_shm_size = 0;
if (info.GetOperation()->hasAttrOfType<IntegerAttr>(SHARED_MEMORY_SIZE)) {
dynamic_shm_size = info.GetOperation()
->getAttrOfType<IntegerAttr>(SHARED_MEMORY_SIZE)
.getInt();
}

auto num_arg = GetOpArgNum(info_);
impl_->grid = dim3(gx, gy, gz);
impl_->block = dim3(bx, by, bz);
impl_->shared_size = 0;
impl_->shared_size = dynamic_shm_size;
impl_->arg_reserve_size = 3; // initial 3 for grid/block/shared_size

// store tensor meta
Expand Down
Loading