Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate release-plz to automate release & crate publish #224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Miaxos
Copy link
Contributor

@Miaxos Miaxos commented Jan 8, 2024

Following #223 this is the corresponding workflow needed to integrate it.

For the tokens creation and set up of the whole things, you'll need to refer to this: https://release-plz.ieni.dev/docs/github/token

Signed-off-by: Anthony Griffon <anthony@griffon.one>
@ihciah
Copy link
Member

ihciah commented Jan 31, 2024

Currently there are multiple crates in this repo, do you have ideas for publishing them separately?

@Miaxos
Copy link
Contributor Author

Miaxos commented Feb 1, 2024

You can publish them separately with release-plz, it's configured in https://github.com/bytedance/monoio/pull/224/files#diff-cb47c6cc6c2e1f89e71763f83f8942d92bed5ac3bd049fb6fb369540be7e1178

@Xuanwo
Copy link
Collaborator

Xuanwo commented Aug 2, 2024

Hi, @Miaxos thank you a lot for raising this PR first. However, I personally feel that we don't need this action right now given our current low frequency of releases.

How about let's close this PR and rethink about it in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants