feat: add exabyte and exbibyte support #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome!! Thanks for the update 😄 |
fdncred
pushed a commit
to nushell/nushell
that referenced
this pull request
Sep 15, 2025
<!-- Thank you for improving Nushell! Please, read our contributing guide: https://github.com/nushell/nushell/blob/main/CONTRIBUTING.md --> Closes #15497. Bumps `bytesize` to [2.1.0](https://github.com/bytesize-rs/bytesize/releases/tag/bytesize-v2.1.0). They merged my PR for adding exabyte and exbibyte support (see bytesize-rs/bytesize#101). However, since bytesize uses `u64` for filesize representation, the maximum exabyte supported is just about `< 10EB`. ## Release notes summary - What our users need to know <!-- This section will be included as part of our release notes. See the contributing guide for more details. Please include only details relevant for users here. Motivation and technical details can be added above or below this section. You may leave this section blank until your PR is finalized. Ask a core team member if you need help filling this section. --> Added support for exabyte and exbibyte filesize format. ## Tasks after submitting <!-- Remove any tasks which aren't relevant for your PR, or add your own --> - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #90.
This adds exabyte and exbibyte support. However, this is limited for up to 16 EiB and 18 EB due to the size of
u64::MAX(not sure what to do to extend this further).