-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a _CSVSource and CSVInput subclass of FileInput #245
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3d3972d
add csv input
awmatheson 3f45b54
modify to subclass
awmatheson b852b63
modify comment
awmatheson 1c97a19
Update pysrc/bytewax/connectors/files.py
awmatheson ff164e4
Update pysrc/bytewax/connectors/files.py
awmatheson b3b79ef
Update pysrc/bytewax/connectors/files.py
awmatheson ba58a61
mod source
awmatheson 461ac2c
revert resume_offset logic
awmatheson c04d8c1
add snapshot and close
awmatheson b4df935
add sample input/output
awmatheson a41d608
Update pysrc/bytewax/connectors/files.py
awmatheson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
from bytewax.connectors.files import CSVInput | ||
from bytewax.dataflow import Dataflow | ||
from bytewax.connectors.stdio import StdOutput | ||
|
||
|
||
flow = Dataflow() | ||
flow.input("inp", CSVInput("examples/sample_data/ec2_metrics.csv", delimiter=",")) | ||
flow.output("out", StdOutput()) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
index,timestamp,value,instance | ||
0,2022-02-24 11:42:08,0.132,24ae8d | ||
0,2022-02-24 11:42:08,0.066,c6585a | ||
0,2022-02-24 11:42:08,42.652,ac20cd | ||
0,2022-02-24 11:42:08,51.846,5f5533 | ||
0,2022-02-24 11:42:08,2.296,fe7f93 | ||
0,2022-02-24 11:42:08,1.732,53ea38 | ||
0,2022-02-24 11:42:08,91.958,825cc2 | ||
0,2022-02-24 11:42:08,0.068,77c1ca |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe call this
DictCSVInput
? This input won't work correctly on CSV files without a header and that would parallel the name of thecsv.DictReader
in the stdlib that works with header-based CSVs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure it makes sense to provide a non-header version right now because that would be the same as lines that you could parse downstream with
next(csv.reader([line]))
if you don't care about the header.I'd like to leave it as is for right now and we can always add a way to skip the header or provide your own header.