Skip to content

Fix the hidden bug when RpcBase was restart #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Fix the hidden bug when RpcBase was restart #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53e05e1
Fix the hidden bug which may cause many inexplicable exceptions. For …
Jul 17, 2023
70ac059
Fix the problem of invalid judgment in the command ChangeConfiguratio…
Jul 17, 2023
b13a07d
Fix the precision loss issue in DateTime.h. I think your test was con…
Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/common/config/OcppConfig.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,8 @@ ocpp::types::ConfigurationStatus OcppConfig::setConfiguration(const std::string&
std::size_t key_is_interval = key.find("Interval");
if (key_is_interval != std::string::npos)
{
std::size_t value_is_negative = key.find("-");
if (value_is_negative)
std::size_t value_is_negative = value.find("-");
if (value_is_negative != std::string::npos)
{
ret = ConfigurationStatus::Rejected;
}
Expand Down
1 change: 1 addition & 0 deletions src/rpc/RpcBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@ void RpcBase::start()
{
// Start reception thread
m_requests_queue.setEnable(true);
m_results_queue.setEnable(true);
m_rx_thread = new std::thread(std::bind(&RpcBase::rxThread, this));
}
}
Expand Down
3 changes: 1 addition & 2 deletions src/types/DateTime.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ class DateTime
m_datetime = _mkgmtime(&t);
#else // _MSC_VER
m_datetime = std::mktime(&t);
m_datetime += t.tm_gmtoff;
m_datetime -= (t.tm_isdst * 3600);
#endif // _MSC_VER
ret = true;
Expand Down Expand Up @@ -179,7 +178,7 @@ class DateTime
#ifdef _MSC_VER
gmtime_s(&t, &m_datetime);
#else // _MSC_VER
gmtime_r(&m_datetime, &t);
localtime_r(&m_datetime, &t);
#endif // _MSC_VER
ss << std::put_time(&t, "%Y-%m-%dT%TZ");
return ss.str();
Expand Down