fix:Improve the reservation logic. #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-jimenez
approved these changes
Sep 20, 2023
c-jimenez
force-pushed
the
fix_Reservation
branch
from
4585f29 to
1f0d9ee
Compare
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with the previous condition. For example, in a charging station with two connectors, if Connector 0 is already in a "Reserved" state and the user first inserts the gun into Connector 1, Connector 1 will transition to a "Preparing" state, and the available_count will be equal to 1. As a result, the condition of available_count > 1 cannot pass the validation, leading to a failed charging initiation.