Change in the decision-making process for reservation recognition #168
Conversation
negative values in "Interval" keys must be rejected,corrected
according to Test Case Id: 027 , in Remote start transaction - connector id shall not be 0
…pen-ocpp into develop_dadashi
Before sending start transaction the status of the connector must be changed to preparing, and this makes us no longer able to determine from the status whether the connector was reserved or not.
…pen-ocpp into develop_dadashi
| } | ||
| else | ||
| { | ||
| response.status = ReservationStatus::Rejected; |
There was a problem hiding this comment.
The ocpp1.6 standard does not say anything about rejecting a ReserveNow with an expiry date that lies in the past. I guess it would make sense when you think about it.
But in terms of sticking to the standard I would actually expect an accepted state, which is then quickly followed by a StatusNotficiation Available. The standard:
When a reservation expires, the Charge Point SHALL terminate the reservation and make the connector
available. The Charge Point SHALL send a status notification to notify the Central System that the reserved
connector is now available.
What do you think?
There was a problem hiding this comment.
Yes, it is true, this issue is not mentioned in the standard, but in my opinion, this should never happen, and if it happens, it is due to a server mistake, and if we follow your suggested method, the server will never realize its mistake, and this mistake will seemas a normal routine.
There was a problem hiding this comment.
Of course, your opinion adheres more to the standard
There was a problem hiding this comment.
I would be in favor of sticking to the standard as much as possible.
Co-authored-by: Habbus <44402940+Habbus@users.noreply.github.com>
| for (const Connector* connector : m_connectors.getConnectors()) | ||
| { | ||
| if ((connector->status == ChargePointStatus::Reserved) && (connector->reservation_expiry_date <= now)) | ||
| if ((connector->reservation_id_tag.length() > 0) && (connector->reservation_expiry_date <= now)) |
There was a problem hiding this comment.
Therre are more places where the suggestion of using !connector->reservation_id_tag.empty(), like here.
Removing the reservation rejection if the time is old and changing the method of checking whether the reservation_id_tag is empty or not
|
@mahdidadashi65 you requested my review, but I think ultimately it is up to @c-jimenez to approve and merge this PR. |
No description provided.