Develop dadashi #99
Merged
Develop dadashi #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of a full update this is the version number of the full list. In case of a differential update it is the version number of the list after the update has been applied. SHALL NOT be -1 or 0 as these have a special meaning in GetLocalListVersion.conf
In the case the ChangeAvailability.req contains ConnectorId = 0, the status change applies to the Charge Point and all Connectors.
c-jimenez
requested changes
Jan 18, 2023
| // Update status | ||
| ChargePointStatus status = ChargePointStatus::Unavailable; | ||
| if (request.type == AvailabilityType::Operative) | ||
| //In the case the ChangeAvailability.req contains ConnectorId = 0, the status change applies to the Charge Point and all Connectors. |
There was a problem hiding this comment.
Good point, I didn't handled this case.
| for(unsigned int i=0;i <= m_connectors.getCount();i++) | ||
| { | ||
| status = ChargePointStatus::Available; | ||
| response.status = m_events_handler.changeAvailabilityRequested(i, request.type); |
There was a problem hiding this comment.
For connector 0, I would have done it differently : I would have notified the user application of a change availability request on connector 0 only. If the request has been accepted, I would have change the status of all the connectors.
By doing this, I would have only 1 status for my response to the Central System reflecting the overall change availability request status of the connectors.
c-jimenez
changed the base branch from
develop
to
fix/local_list_change_availability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.