Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept a callable function to Mux::mount() which can build a child mux #63

Merged
merged 1 commit into from
Nov 7, 2014

Conversation

rubensayshi
Copy link
Contributor

example usage:

$mux = new Mux();
$mux->mount('/api', function(Mux $mux) {
    $mux->get('/endpoint', ['Controller', 'actionMethod']);
});

if you're okay with this addition I'll add a bunch of tests to cover it ( I just hate writing tests when the feature itself gets denied :P )

@c9s
Copy link
Owner

c9s commented Nov 7, 2014

Looks good, I'd love to merge this PR

c9s added a commit that referenced this pull request Nov 7, 2014
accept a callable function to `Mux::mount()` which can build a child mux
@c9s c9s merged commit a3eb142 into c9s:master Nov 7, 2014
@c9s
Copy link
Owner

c9s commented Nov 7, 2014

i think we might also need to add this to extension for compatibility

@rubensayshi
Copy link
Contributor Author

hmm, yea I know nothing about PHP extensions, yet ...

@rubensayshi
Copy link
Contributor Author

can you reopen and merge again, I added a unittest for it ;-)

@c9s
Copy link
Owner

c9s commented Nov 7, 2014

open a new PR for this?

[Sent from iPhone]

Ruben de Vries notifications@github.com ©ó 2014¦~11¤ë7¤é 23:15 ¼g¹D¡G

can you reopen and merge again, I added a unittest for it ;-)

¡X
Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants