Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added skin.show_gsva to service_config #7140

Merged
merged 2 commits into from Feb 11, 2020
Merged

Added skin.show_gsva to service_config #7140

merged 2 commits into from Feb 11, 2020

Conversation

ngocnn1104
Copy link
Contributor

Added a new property into config_service for displaying geneset feature on frontend

@jjgao jjgao temporarily deployed to cbioportal-config-servi-p671kr February 10, 2020 16:50 Inactive
@jjgao jjgao temporarily deployed to cbioportal-config-servi-p671kr February 11, 2020 09:35 Inactive
oplantalech
oplantalech approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@oplantalech oplantalech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ngocnn1104. I have added documentation.

@oplantalech
Copy link
Contributor

@alisman I have tested the PR and it fixes #7116. Feel free to review or directly merge.

@oplantalech
Copy link
Contributor

@alisman Can this PR be merged?

@alisman alisman merged commit 71e9178 into master Feb 11, 2020
@inodb inodb added the devops label Feb 13, 2020
@jjgao jjgao deleted the config_service_geneset branch April 27, 2020 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisman alisman alisman approved these changes

@oplantalech oplantalech oplantalech approved these changes

Assignees
No one assigned
Labels
devops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ngocnn1104 @oplantalech @alisman @jjgao @inodb