Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alert notification flow #328

Merged
merged 2 commits into from
Jul 31, 2023
Merged

fix: alert notification flow #328

merged 2 commits into from
Jul 31, 2023

Conversation

gassara-kys
Copy link
Collaborator

アラートの通知条件として、「紐づくFindingに変更があったか」どうかで通知制御を行っている箇所を「新規Findingがあったか」に変更したいです

その他、以下の修正をしています。

  • finding_idをuint32型で取り扱っている箇所をuint64に変更(42億くらいまで行くとIDの不整合が発生する)
  • typo修正

Copy link
Contributor

@iiiidaaa iiiidaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gassara-kys gassara-kys merged commit 13566fa into master Jul 31, 2023
@gassara-kys gassara-kys deleted the fix-alert branch July 31, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants