modify deny page #360
Merged
modify deny page #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
セキュリティレビューを実施しました。 By RISKEN review |
senk8
commented
Mar 1, 2024
src/view/error/Deny.vue
Outdated
| <v-btn color="primary" @click="goHome">{{ | ||
| $t(`btn['SIGNIN']`) | ||
| }}</v-btn> | ||
| <v-btn |
There was a problem hiding this comment.
元々あったSigninボタンですが、削除してみました。
- サインインと書いてあるが、ホーム画面に戻るだけのため
- ボタンが複数あるとわかりづらいため
There was a problem hiding this comment.
権限がないパターンとセッション切れのパターンがあるので、「ホームに戻る」ボタンも追加するのはどうでしょうか？
iiiidaaa
reviewed
Mar 7, 2024
|
@iiiidaaa @gassara-kys 
|
|
ボタン縦配置にできますか？（権限申請が必要な人を救いたいので少し差別化したい） |
|
@gassara-kys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
背景
403のエラーメッセージがわかりづらく、ユーザーが403画面の表示を見た時に何をすれば解決できるかわからない。そのため、管理者にリクエストを送るように促すようにしてUXを向上させる。
実装概要
バックエンドの改修はこちらのPRで行っています。
ca-risken/core#353
ca-risken/gateway#171
４０３エラー画面の改修
当該画面
https://github.com/ca-risken/web/blob/master/src/view/error/Deny.vue
ボタンを追加します。
- project_id
- user_id
文言のアップデート
REQUEST PROJECT ROLE
REQUEST PROJECT ROLE COMPLETED
Sorry, access denied or time out your session... Please request access rights to the administrator if necessary.
観点
動作確認