Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint on travis and refactory #70

Merged
merged 13 commits into from
Mar 9, 2019
Merged

lint on travis and refactory #70

merged 13 commits into from
Mar 9, 2019

Conversation

caarlos0
Copy link
Owner

@caarlos0 caarlos0 commented Mar 8, 2019

No description provided.

@todo
Copy link

todo bot commented Mar 8, 2019

need to improve this method...

env/env.go

Lines 167 to 172 in 4bba4b5

// TODO: need to improve this method...
// nolint: gocyclo
func set(field reflect.Value, refType reflect.StructField, value string, funcMap CustomParsers) error {
// use custom parser if configured for this type
parserFunc, ok := funcMap[refType.Type]
if ok {


This comment was generated by todo based on a TODO comment in 4bba4b5 in #70. cc @caarlos0.

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 4bba4b5 on lint into 9a320ff on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 4bba4b5 on lint into 9a320ff on master.

@coveralls
Copy link

coveralls commented Mar 8, 2019

Coverage Status

Coverage remained the same at ?% when pulling 2ca7015 on lint into 9a320ff on master.

@todo
Copy link

todo bot commented Mar 9, 2019

this is the only test failing right now, fix it.

env/env_test.go

Lines 578 to 581 in ba219f0

// TODO: this is the only test failing right now, fix it.
func TestCustomParserNotCalledForNonAlias(t *testing.T) {
type T uint64
type U uint64


This comment was generated by todo based on a TODO comment in ba219f0 in #70. cc @caarlos0.

@todo
Copy link

todo bot commented Mar 9, 2019

change this to a param instead of global

env/env.go

Lines 152 to 155 in 36203e8

// TODO: change this to a param instead of global
if OnEnvVarSet != nil {
OnEnvVarSet(refTypeField, value)
}


This comment was generated by todo based on a TODO comment in 36203e8 in #70. cc @caarlos0.

@caarlos0 caarlos0 changed the title lint on travis lint on travis and refactory Mar 9, 2019
@codecov
Copy link

codecov bot commented Mar 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9a320ff). Click here to learn what that means.
The diff coverage is 97.91%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #70   +/-   ##
=========================================
  Coverage          ?   92.16%           
=========================================
  Files             ?        3           
  Lines             ?      217           
  Branches          ?        0           
=========================================
  Hits              ?      200           
  Misses            ?       13           
  Partials          ?        4
Impacted Files Coverage Δ
parsers/parsers.go 80% <83.33%> (ø)
env.go 96.96% <98.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a320ff...ed82bdc. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants