Allow omitting unit #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey, yeah this looks good! thanks wanna add to the help as well? |
|
I'm not sure how to add the help 😅 But I'd be glad to add it. The actual help message apparently is "timer is like sleep, but with progress report", so I'm not sure how to insert the information about defaulting to seconds, since there is not really a mention to units. I added a line to the README.md (got the info from the docs), but I also don't know how the man pages are generated, I think it would be nice to mention the default unit as seconds in the man page as well. |
|
man pages are auto-generated, this looks good, thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello and good day. I'm not really sure how to contribute to this project, if I could just open a PR or not, so if this was not OK please let me know and lets close it.
The thing is, I saw an open issue where it was requestes to allow ommiting units, just like the regular sleep command, where it defaults to seconds when no unit is passed. So I did kind of fix to that. I'm not a go programmer, I recently started learning it, so I don't know if my implementation was a good idea or not. I mutated the state of
arg[0], this sounds fishy, but I looked like it wasn't used anywhere else.Anyways, if this is a valid feature (ommiting units), please let me know. And if it is the case, I think it could be stated in the help/manual/readme that it defaults to seconds.
Solves #34