Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exunit tags #34

Merged
merged 7 commits into from
Nov 18, 2018
Merged

Exunit tags #34

merged 7 commits into from
Nov 18, 2018

Conversation

mgwidmann
Copy link
Member

No description provided.

@maryolivier
Copy link

Hello! Wondering if there is anything I can do to help get this merged. Very excited for this feature.

@nicholasjhenry
Copy link
Collaborator

@mgwidmann could you let me know what the status of this branch is and we'll be happy to finish this up. Thanks!

@revati
Copy link
Collaborator

revati commented Nov 4, 2018

What is status about this? When could this be merged? The absence of this feature blocks me for using this library :(

I just forked this project and merged it into. Took, like 5 seconds, as merge conflicts are trivial

@nicholasjhenry
Copy link
Collaborator

@revati We're dependent on @mgwidmann to give us a status update. If we don't hear from him before the EOY I'll review the related issues and see if it meets the desired requirements.

@nicholasjhenry
Copy link
Collaborator

@revati As you have branched off from here for your PR's. Do you consider this PR complete? I haven't had a chance to look at it.

@revati
Copy link
Collaborator

revati commented Nov 9, 2018

it supports @some_tag and @other_tag value

then I can run only tagged events mix test --only some_tag or mix test --only other_tag:value

@timeout 1000 also seems to work as expected.

conflicts are trivial version mismatches.

@revati revati mentioned this pull request Nov 9, 2018
@mgwidmann
Copy link
Member Author

Yeah this should be good to go once merge conflicts are resolved, I can't remember why I didn't merge it yet, perhaps just because I was waiting on a release to put it into.

@revati revati merged commit cbc0432 into master Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants