Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add yamlfmt #453

Merged
merged 2 commits into from
Jun 6, 2024
Merged

feat: add yamlfmt #453

merged 2 commits into from
Jun 6, 2024

Conversation

joscha
Copy link
Contributor

@joscha joscha commented Jun 5, 2024

This adds yamlfmt with a minimal configuration option for specifying a config file.

As https://github.com/cachix/git-hooks.nix always has an ignored .pre-commit-config.yaml in the repository, the smallest possible configuration file is usually:

.yamlfmt:

gitignore_excludes: true

which tells the hook to ignore it's own precommit config.

closes #341 // cc @bryanhonof @domenkozar

@bryanhonof bryanhonof mentioned this pull request Jun 5, 2024
Copy link

@bryanhonof bryanhonof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for picking this up again, I lost track of time a bit. 😅

@joscha
Copy link
Contributor Author

joscha commented Jun 5, 2024

Looks good to me.

Great. I didn't need to add anything here:

"yamllint" = [ "configPath" ];

as it's a new addition, correct?

Also, I forgot to add it to

, yamllint
, will just make that change quickly.

@domenkozar domenkozar merged commit cc4d466 into cachix:master Jun 6, 2024
4 checks passed
@joscha joscha deleted the joscha/add-yamlfmt branch June 6, 2024 10:21
joscha added a commit to planet-a-ventures/affinity-node that referenced this pull request Jun 6, 2024
joscha added a commit to planet-a-ventures/affinity-node that referenced this pull request Jun 6, 2024
* chore: update flake.lock

Flake lock file updates:

• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/b57526ee5cf47504b759cda0b3655a73b40e9a61' (2024-06-05)
  → 'github:NixOS/nixpkgs/42333a35f71e157614cc8afc1479de764c1e5ddc' (2024-06-06)
• Updated input 'pre-commit-hooks-nix':
    'github:cachix/pre-commit-hooks.nix/0e8fcc54b842ad8428c9e705cb5994eaf05c26a0' (2024-05-20)
  → 'github:cachix/pre-commit-hooks.nix/cc4d466cb1254af050ff7bdf47f6d404a7c646d1' (2024-06-06)

* build(pre-commit): Added yamlfmt

cachix/git-hooks.nix#453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants