Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add typstyle #454

Merged
merged 3 commits into from
Jun 20, 2024
Merged

feat: add typstyle #454

merged 3 commits into from
Jun 20, 2024

Conversation

leana8959
Copy link
Contributor

Hello,

I have added typstyle, a formatter for typst.

Though, there's a little issue: it's not in the version of nixpkgs pinned by this project, and it won't work. What would be a good solution ?

Thanks and have a nice day :)

@leana8959
Copy link
Contributor Author

Psst, The CI failed because typstyle is not in the nixpkgs pinned in the flake.

Copy link
Member

@sandydoo sandydoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll bump nixpkgs so that this works out of the box. We'll still need the below changes to ensure it works with older package sets.

nix/tools.nix Outdated Show resolved Hide resolved
modules/hooks.nix Outdated Show resolved Hide resolved
@sandydoo sandydoo added the new-hook A request for a new hook label Jun 19, 2024
@leana8959
Copy link
Contributor Author

The requested changes were added :)

@leana8959 leana8959 marked this pull request as ready for review June 19, 2024 19:16
@domenkozar domenkozar merged commit fb0bfd8 into cachix:master Jun 20, 2024
4 checks passed
@sandydoo
Copy link
Member

Thanks, @leana8959!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-hook A request for a new hook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants