feat: add generic response interceptors #6232
Conversation
|
Nice feature! Thanks @dunglas ! |
dunglas
force-pushed
the
feat/response-interceptors
branch
2 times, most recently
from
7cce44a
to
8aa881f
Compare
|
Looking good here. @francislavoie any thoughts on the Caddyfile implementation? |
| // delegate the parsing of handle_response to the caller, | ||
| // since we need the httpcaddyfile.Helper to parse subroutes. | ||
| // See h.FinalizeUnmarshalCaddyfile | ||
| i.handleResponseSegments = append(i.handleResponseSegments, d.NewFromNextSegment()) |
There was a problem hiding this comment.
Since this isn't embedded within another directive, I think we don't need the finalize thing here. I think we can immediately parse the current segment as a handler and add that to the config. Then we can delete handleResponseSegments
There was a problem hiding this comment.
Do you have an idea of how we can do that @francislavoie? We need a httpcaddyfile.Helper to call ParseSegmentAsSubroute().
There was a problem hiding this comment.
Oooh right. I'll think about it.
|
@dunglas I'll probably tag 2.8 beta 1 this week; it'd be nice to get this in 2.8 beta 1, but if not, maybe we can get it in beta 2 or the RC. |
dunglas
force-pushed
the
feat/response-interceptors
branch
from
3138fa3
to
8e39b5a
Compare
Co-authored-by: Francis Lavoie <lavofr@gmail.com>
In proxy mode, Caddy allows intercepting and modifying responses coming from upstream servers.
This is especially useful for implementing
X-Sendfile/X-Accel-Redirect-like features.However, the current implementation of this feature is only available in proxy mode and doesn't allow to intercept and modify responses created by modules.
This makes it impossible to use features like
X-Sendfilewith FrankenPHP, https://github.com/mliezun/caddy-snake, and other similar potential modules (LUA module, etc).This patch implements a generic implementation of response interceptors that behaves similarly to the
reverse_proxyhandle_responsesubdirective.It currently does not support the
copy_responseandcopy_response_headerssubdirective, but it should be easy to add support for these features in future Pull Requests.It should also be possible, in the future, to replace the current
reverse_proxyspecific implementation with this new more generic one, but it is out of scope for this PR.Closes dunglas/frankenphp#365. Closes dunglas/frankenphp#396.