fix<data converter>: fail open on exception not found #1027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijiesheng
requested review from
Groxx,
abhishekj720,
natemort,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
natemort
reviewed
Sep 29, 2025
| classType = Class.forName(className); | ||
| } catch (ClassNotFoundException e) { | ||
| throw new IOException("Cannot deserialize " + className + " exception", e); | ||
| return null; |
There was a problem hiding this comment.
Rather than returning null we should return some generic Exception type (indicating that we couldn't deserialize it) or try and deserialize the Exception as some type that we know.
For example, we could introduce an ApplicationFailureException, set classType = ApplicationFailureException.class, and deserialize the json object into that.
… converter Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
…ack on this exception instead Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
shijiesheng
force-pushed
the
data-converter-not-found-exception
branch
from
87f15a1 to
700479d
Compare
natemort
reviewed
Oct 2, 2025
| classType = Class.forName(className); | ||
| } catch (ClassNotFoundException e) { | ||
| throw new IOException("Cannot deserialize " + className + " exception", e); | ||
| return (T) new ApplicationFailureException("Class not found: " + className); |
There was a problem hiding this comment.
I think doing classType = ApplicationFailureException.class is more useful to the user. They'll still get their original stacktrace and everything, just with a different type of exception.
Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
shijiesheng
force-pushed
the
data-converter-not-found-exception
branch
from
01dbd13 to
0705365
Compare
natemort
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Default data converter would throw I/O exception and thus fail workflow processing if the exception no longer exists. This PR changes the behavior by return null instead.
Why?
In V4, thrift exceptions will be removed and thus this is needed to avoid breaking existing workflows.
How did you test it?
Unit Test
Potential risks
Release notes
Documentation Changes