Skip to content

Conversation

shijiesheng
Copy link
Member

What changed?

  • fix unhandled exceptions in WorkflowServiceTChannel
  • add more test coverage in the whole package

Why?
unit test coverage

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (1d0e355) to head (7fcd543).
Report is 10 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
...cadence/serviceclient/WorkflowServiceTChannel.java 89.71% <100.00%> (+14.73%) ⬆️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d0e355...7fcd543. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2641

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 93 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.5%) to 80.761%

Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/cadence/internal/testservice/TestWorkflowMutableStateImpl.java 1 85.33%
src/main/java/com/uber/cadence/serviceclient/IWorkflowServiceBase.java 2 96.84%
src/main/java/com/uber/cadence/internal/common/RetryParameters.java 8 84.62%
src/main/java/com/uber/cadence/client/ActivityCompletionException.java 14 58.82%
src/main/java/com/uber/cadence/internal/worker/PollerOptions.java 15 79.73%
src/main/java/com/uber/cadence/internal/worker/PollerAutoScalerOptions.java 17 0.0%
src/main/java/com/uber/cadence/internal/replay/ExecuteActivityParameters.java 36 44.62%
Totals Coverage Status
Change from base Build 2635: 0.5%
Covered Lines: 15662
Relevant Lines: 19393

💛 - Coveralls

@shijiesheng shijiesheng merged commit 34cb4f5 into cadence-workflow:master Nov 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants