Integrate decision handler into worker #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timl3136
changed the title
Signed-off-by: Tim Li <ltim@uber.com>
timl3136
force-pushed
the
handler-integrate
branch
from
a313c42 to
324de45
Compare
Signed-off-by: Tim Li <ltim@uber.com>
timl3136
force-pushed
the
handler-integrate
branch
from
c14ba05 to
428f0ac
Compare
timl3136
force-pushed
the
handler-integrate
branch
from
a40f6a6 to
073dc34
Compare
shijiesheng
reviewed
Sep 19, 2025
| # Deserialize the input using the client's data converter | ||
| try: | ||
| # Use from_data method with a single type hint of None (no type conversion) | ||
| input_data_list = await self._context.client().data_converter.from_data(started_attrs.input, [None]) |
There was a problem hiding this comment.
type hints are needed here. I recommend creating a WorkflowDefinition class similar to activitydefinition. And pass it from registry.
Signed-off-by: Tim Li <ltim@uber.com>
Signed-off-by: Tim Li <ltim@uber.com>
Signed-off-by: Tim Li <ltim@uber.com>
shijiesheng
reviewed
Oct 2, 2025
shijiesheng
reviewed
Oct 2, 2025
shijiesheng
reviewed
Oct 2, 2025
shijiesheng
reviewed
Oct 2, 2025
| "task_token": task.task_token[:16].hex() if task.task_token else None | ||
| } | ||
| ) | ||
| except Exception as e: |
There was a problem hiding this comment.
error needs to be thrown out
There was a problem hiding this comment.
For this part, I think we actually don't need to raise error here since if decision task failure responses failed to sent to server, it will timeout and retry the decision task anyway, there is no need to disrupt the worker's execution flow as that would be counterproductive
shijiesheng
reviewed
Oct 2, 2025
Signed-off-by: Tim Li <ltim@uber.com>
Signed-off-by: Tim Li <ltim@uber.com>
shijiesheng
approved these changes
Oct 2, 2025
| ) | ||
| # Use thread-safe cache to get or create workflow engine | ||
| cache_key = (workflow_id, run_id) | ||
| with self._cache_lock: |
There was a problem hiding this comment.
current cache is unbounded. We need a LFU cache here. Maybe add a TODO for next PR
Signed-off-by: Tim Li <ltim@uber.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
integrate decision handler into worker
Why?
now that handler is implemented, we will integrate that with decision worker
How did you test it?
unit test
Potential risks
Release notes
Documentation Changes