Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docking 1.11.0 not compatible with tabbed_view 1.17.0 #28

Closed
filly82 opened this issue May 26, 2023 · 2 comments
Closed

docking 1.11.0 not compatible with tabbed_view 1.17.0 #28

filly82 opened this issue May 26, 2023 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@filly82
Copy link

filly82 commented May 26, 2023

after running pub upgrade got the following error

/Local/Pub/Cache/hosted/pub.dev/docking-1.11.0/lib/src/internal/widgets/docking_item_widget.dart(91,9): error GC6690633: No named parameter with the name 'draggableTabBuilder'

Exception: Build process failed.

only solution for now is to override tabbed_view to version 1.16.X

@caduandrade
Copy link
Owner

Hi @filly82! You shouldn't declare the tabbed_view in pubspec.yaml because it's already published inside the docking ok? I haven't released the new docking version containing tabbed_view 1.17.0 yet. There is a UI issue to be resolved. The tabbed_view 1.17.0 allows reordering of tabs by dragging them on top of others. But on the dock, this area is reserved to create a north split. If this reserved area only appears in the part where there are no tabs, it can cause a problem when there are many tabs occupying all the available space, in which case you would not be able to split.

Screenshot_20230526_083919

🤔

@filly82
Copy link
Author

filly82 commented May 26, 2023

I had to declare it as a dependency_override because docking itself seemed to update tabbed_view to 1.17 when Running flutter upgrade without me doing anything.
without my override the build process fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants