Drop -Werror

[lanodan]

Please drop -Werror, at least on releases.

It makes no sense to do that and of course it makes cage fails when you compile it with clang and it is doomed to fail on any compiler or warning flag you didn’t test.

[Hjdskes]

It makes no sense to do that

Care to elaborate? I like to get as much assistance from the compiler as possible. I compile Cage on Arch w/ GCC & Clang, Alpine w/ GCC and FreeBSD w/ Clang.

Also, I sense an undertone I don't like. Please don't do that. Just describe the issue you're having and try to convince me to change with sound arguments, not frustrations.

[lanodan]

Well here is the build.log then. (EDIT: And here is the one without -Werror which maybe has more warnings btw: build.log )

I disabled “-Werror” btw as it should just not be there by default in releases, as it means that if the building environment is different from yours (compilers, libc, flags, …) it’ll probably errornously fail instead of successfully manage to build.

I could understand using it when you’re in development, but in releases you’ll just annoy packagers, specially as the release could end up failling rebuilding after an update.

[Hjdskes]

I'll see if I can compile a list of compile flags to use instead of -Werror. Open to suggestions on what to include/exclude.

[lanodan]

I'll see if I can compile a list of compile flags to use instead of `-Werror`. Open to suggestions on what to include/exclude.

Adding ``-Wall`` and maybe ``-Wextra`` is probably a good idea but you might have to add some ``-Wno-`` as some are quite spammy. From gcc(1) manpage: -Wall This enables all the warnings about constructions that some users consider questionable, and that are easy to avoid (or modify to prevent the warning), even in conjunction with macros. […] Note that some warning flags are not implied by -Wall. Some of them warn about constructions that users generally do not consider questionable, but which occasionally you might wish to check for; others warn about constructions that are necessary or hard to avoid in some cases, and there is no simple way to modify the code to suppress the warning. Some of them are enabled by -Wextra but many of them must be enabled individually. -Wextra This enables some extra warning flags that are not enabled by -Wall. (This option used to be called -W. The older name is still supported, but the newer name is more descriptive.)

[JakeSays]

I would ask for this as well. I fully understand the value of -Werror while developing cage itself, but for the rest of us having a build option to turn it off would be very helpful.

[lanodan]

[2019-06-01 22:15:05-0700] Big Jake:

I would ask for this as well. I fully understand the value of -Werror while developing cage itself, but for the rest of us having a build option to turn it off would be very helpful.

Which you can actually do by passing -Dwerror=false to meson at configure time.

[JakeSays]

@lanodan perfect! Thanks