Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.2] feat(*): support to add a http.Handler directly to the router #358

Merged
merged 2 commits into from
Sep 23, 2020
Merged

[release-0.2] feat(*): support to add a http.Handler directly to the router #358

merged 2 commits into from
Sep 23, 2020

Conversation

caicloud-bot
Copy link
Contributor

This is an automated cherry-pick of #342

/assign whalecold

@caicloud-bot caicloud-bot mentioned this pull request Sep 22, 2020
Merged
@caicloud-bot
Copy link
Contributor Author

@caicloud-bot: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the caicloud/tools repository.

@caicloud-bot caicloud-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 22, 2020
@whalecold
Copy link
Member

/retest

@iawia002
Copy link

/release-note-none
/lgtm

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 23, 2020
@caicloud-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iawia002

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2020
@caicloud-bot caicloud-bot merged commit 10710d4 into caicloud:release-0.2 Sep 23, 2020
iawia002 added a commit that referenced this pull request Oct 21, 2020
@iawia002
Revert "[release-0.2] feat(*): support to add a http.Handler directly…
3029028 
… to the router (#358)"

This reverts commit 10710d4.
@iawia002 iawia002 mentioned this pull request Oct 21, 2020
Merged
caicloud-bot pushed a commit that referenced this pull request Oct 21, 2020
Revert "[release-0.2] feat(*): support to add a http.Handler directly…
fcf8dc7 
… to the router" (#366)

* Revert "[release-0.2] feat(*): support to add a http.Handler directly to the router (#358)"

This reverts commit 10710d4.

* fix(*): update examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@iawia002 iawia002

@whalecold whalecold

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caicloud-bot @whalecold @iawia002